linux-kernel - Re: [PATCH] scsi: sg: add sg_remove_request in sg_common

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a19ba1a-1afe-2938-daea-96b1f14570cf@interlog.com>
Date:   Mon, 13 Apr 2020 21:17:26 -0400
From:   Douglas Gilbert <dgilbert@...erlog.com>
To:     Li Bin <huawei.libin@...wei.com>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        xiexiuqi@...wei.com
Subject: Re: [PATCH] scsi: sg: add sg_remove_request in sg_common_write

On 2020-04-13 7:29 a.m., Li Bin wrote:
> If the dxfer_len is greater than 256M that the request is invalid,
s/that/then/
> it should call sg_remove_request in sg_common_write.
> 
> Fixes: f930c7043663 ("scsi: sg: only check for dxfer_len greater than 256M")

Code fix is fine, please replace the "that" in the first comment line
above with "then".

Acked-by: Douglas Gilbert <dgilbert@...erlog.com>

> Signed-off-by: Li Bin <huawei.libin@...wei.com>
> ---
>   drivers/scsi/sg.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 4e6af592..9c0ee19 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -793,8 +793,10 @@ static int get_sg_io_pack_id(int *pack_id, void __user *buf, size_t count)
>   			"sg_common_write:  scsi opcode=0x%02x, cmd_size=%d\n",
>   			(int) cmnd[0], (int) hp->cmd_len));
>   
> -	if (hp->dxfer_len >= SZ_256M)
> +	if (hp->dxfer_len >= SZ_256M) {
> +		sg_remove_request(sfp, srp);
>   		return -EINVAL;
> +	}
>   
>   	k = sg_start_req(srp, cmnd);
>   	if (k) {
>