linux-kernel - Re: [PATCH 0/5] blktrace: fix use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200414073816.GC4111599@kroah.com>
Date:   Tue, 14 Apr 2020 09:38:16 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     axboe@...nel.dk, viro@...iv.linux.org.uk, bvanassche@....org,
        rostedt@...dmis.org, mingo@...hat.com, jack@...e.cz,
        ming.lei@...hat.com, nstange@...e.de, akpm@...ux-foundation.org,
        mhocko@...e.com, yukuai3@...wei.com, linux-block@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] blktrace: fix use after free

On Tue, Apr 14, 2020 at 04:18:57AM +0000, Luis Chamberlain wrote:
> After two iterations of RFCs I think this is ready now. I've taken
> the feedback from the last series, both on code and commit log.
> I've also extended the commit log on the last patch to also explain
> how the original shift to async request_queue removal turned out
> to actually be a userspace regression and added a respective fixes
> tag for it.
> 
> You can find these patches on my 20200414-dev-blkqueue-defer-removal-patch-v1
> branch based on linux-next tag next-20200414 on kernel.org [0].
> 
> Further review and rants are appreciated.
> 
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200414-dev-blkqueue-defer-removal
> 
> Luis Chamberlain (5):
>   block: move main block debugfs initialization to its own file
>   blktrace: fix debugfs use after free
>   blktrace: refcount the request_queue during ioctl
>   mm/swapfile: refcount block and queue before using
>     blkcg_schedule_throttle()
>   block: revert back to synchronous request_queue removal

Looks good from a debugfs point of view, thanks for doing this cleanup.

greg k-h