linux-kernel - Re: [v2 PATCH 5/5] RISC-V: Add EFI stub support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 14 Apr 2020 09:28:47 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Atish Patra <atish.patra@....com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [v2 PATCH 5/5] RISC-V: Add EFI stub support.

Hi Atish,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.7-rc1 next-20200413]
[cannot apply to efi/next arm/for-next arm64/for-next/core linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Atish-Patra/Add-UEFI-support-for-RISC-V/20200414-053224
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8f3d9f354286745c751374f5f1fcafee6b3f3136
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/video/fbdev/efifb.c: In function 'efifb_setup':
>> drivers/video/fbdev/efifb.c:275:4: error: implicit declaration of function 'efifb_setup_from_dmi' [-Werror=implicit-function-declaration]
     275 |    efifb_setup_from_dmi(&screen_info, this_opt);
         |    ^~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/efifb_setup_from_dmi +275 drivers/video/fbdev/efifb.c

7c83172b98e569 drivers/video/efifb.c       Huang, Ying     2007-11-28  266  
e6816a8d855494 drivers/video/efifb.c       David Herrmann  2013-08-02  267  static int efifb_setup(char *options)
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  268  {
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  269  	char *this_opt;
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  270  
b4aa0163056b6c drivers/video/efifb.c       Matthew Garrett 2012-04-16  271  	if (options && *options) {
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  272  		while ((this_opt = strsep(&options, ",")) != NULL) {
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  273  			if (!*this_opt) continue;
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  274  
21289ec02b41c4 drivers/video/fbdev/efifb.c Ard Biesheuvel  2016-04-25 @275  			efifb_setup_from_dmi(&screen_info, this_opt);
21289ec02b41c4 drivers/video/fbdev/efifb.c Ard Biesheuvel  2016-04-25  276  
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  277  			if (!strncmp(this_opt, "base:", 5))
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  278  				screen_info.lfb_base = simple_strtoul(this_opt+5, NULL, 0);
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  279  			else if (!strncmp(this_opt, "stride:", 7))
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  280  				screen_info.lfb_linelength = simple_strtoul(this_opt+7, NULL, 0) * 4;
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  281  			else if (!strncmp(this_opt, "height:", 7))
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  282  				screen_info.lfb_height = simple_strtoul(this_opt+7, NULL, 0);
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  283  			else if (!strncmp(this_opt, "width:", 6))
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  284  				screen_info.lfb_width = simple_strtoul(this_opt+6, NULL, 0);
dd0c41f8a7e0ba drivers/video/fbdev/efifb.c Dave Airlie     2017-07-31  285  			else if (!strcmp(this_opt, "nowc"))
38ac0287b7f4f3 drivers/video/fbdev/efifb.c Ard Biesheuvel  2018-07-11  286  				mem_flags &= ~EFI_MEMORY_WC;
cf7389b8095fab drivers/video/fbdev/efifb.c Hans de Goede   2018-09-26  287  			else if (!strcmp(this_opt, "nobgrt"))
cf7389b8095fab drivers/video/fbdev/efifb.c Hans de Goede   2018-09-26  288  				use_bgrt = false;
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  289  		}
b4aa0163056b6c drivers/video/efifb.c       Matthew Garrett 2012-04-16  290  	}
b4aa0163056b6c drivers/video/efifb.c       Matthew Garrett 2012-04-16  291  
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  292  	return 0;
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  293  }
7c08c9ae0c1458 drivers/video/efifb.c       Peter Jones     2008-10-15  294  

:::::: The code at line 275 was first introduced by commit
:::::: 21289ec02b41c4b928a0b3de1778b325d714eea3 x86/efi/efifb: Move DMI based quirks handling out of generic code

:::::: TO: Ard Biesheuvel <ard.biesheuvel@...aro.org>
:::::: CC: Ingo Molnar <mingo@...nel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (63893 bytes)