linux-kernel - Re: [PATCH 1/4] remoteproc: Fix a bug in rproc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <e459f807-4c61-257b-b7b5-dd767202c435@web.de>
Date:   Tue, 14 Apr 2020 10:24:26 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Mathieu Poirier <mathieu.poirier@...aro.org>,
        Alex Elder <elder@...aro.org>, linux-remoteproc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Ohad Ben-Cohen <ohad@...ery.com>, Suman Anna <s-anna@...com>
Subject: Re: [PATCH 1/4] remoteproc: Fix a bug in rproc_alloc()

> I'm not actually sure this case causes an observable problem, but
> it's incorrect.  Fix this by initializing the notifyids field before
> calling ida_simple_get() in rproc_alloc().

I suggest to improve the commit message.

* Can the information “field initialisation” be more helpful than “bug”
  in the patch subject?

* Will the tag “Fixes” become relevant?

Regards,
Markus