linux-kernel - Re: [PATCH] Staging: fbtft : fbtft-bus: fixed two checkpatch errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200414082506.GB10645@kroah.com>
Date:   Tue, 14 Apr 2020 10:25:06 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     carlosteniswarrior@...il.com
Cc:     linux@...eg.net, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: fbtft : fbtft-bus: fixed two checkpatch errors

On Tue, Apr 14, 2020 at 09:30:47AM +0200, carlosteniswarrior@...il.com wrote:
> From: Carlos Guerrero Álvarez <carlosteniswarrior@...il.com>
> 
> Fixed two checkpatch space prohibited before that close parenthesis errors.
> 
> Signed-off-by: Carlos Guerrero Álvarez <carlosteniswarrior@...il.com>
> ---
>  drivers/staging/fbtft/fbtft-bus.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fbtft-bus.c b/drivers/staging/fbtft/fbtft-bus.c
> index 63c65dd67b17..cdb451dd3fde 100644
> --- a/drivers/staging/fbtft/fbtft-bus.c
> +++ b/drivers/staging/fbtft/fbtft-bus.c
> @@ -62,9 +62,9 @@ out:									      \
>  }                                                                             \
>  EXPORT_SYMBOL(func);
>  
> -define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8, )
> +define_fbtft_write_reg(fbtft_write_reg8_bus8, u8, u8,)
>  define_fbtft_write_reg(fbtft_write_reg16_bus8, __be16, u16, cpu_to_be16)
> -define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16, )
> +define_fbtft_write_reg(fbtft_write_reg16_bus16, u16, u16,)

If I remember correct, the original code here is required, due to how
some older versions of gcc works.

Did you test-build this?  Did it work properly?

I would just leave this alone,

greg k-h