linux-kernel - Re: [PATCH 2/2 v8] iio: Add SEMTECH SX9310/9311 sensor driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Apr 2020 12:10:56 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Daniel Campello <campello@...gle.com>
Cc:     LKML <devicetree@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Gwendal Grignou <gwendal@...omium.org>,
        Enrico Granata <egranata@...omium.org>,
        Andreas Klinger <ak@...klinger.de>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-iio <linux-iio@...r.kernel.org>
Subject: Re: [PATCH 2/2 v8] iio: Add SEMTECH SX9310/9311 sensor driver

On Tue, Apr 14, 2020 at 1:56 AM Daniel Campello <campello@...gle.com> wrote:
> On Fri, Apr 10, 2020 at 4:52 AM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> > On Thu, Apr 9, 2020 at 2:54 AM Daniel Campello <campello@...omium.org> wrote:

As far I understand you agreed on the rest.
Correct?

...

> > > Signed-off-by: Gwendal Grignou <gwendal@...omium.org>
> > > Signed-off-by: Enrico Granata <egranata@...omium.org>
> >
> > This is not understandable. Are they who helped you develop the code
> > (we have a special tag, i.e. Co-developed-by in addition to SoB), or
> > just people in the middle? Then the question is, how come author is
> > you and not Gwendal?
> >
> This patch was initially developed by Gwendal and Enrico (here:
> crrev.com/c/1089826).

So, tags should include
 SoB: Gwendal ...
 Co-developed-by: Enrico ...
 SoB: Enrico ...
 Co-developed-by: yours (if you developed it)
 SoB: yours

and on top git commit --amend --author="Gwendal  ..."

...

> > > +#define SX9310_REG_IRQ_MSK                             0x03
> >
> > Is MSK abbreviation in datasheet? Please spell it how it's in datasheet.
> Yes, they indead use MSK.

Okay!


-- 
With Best Regards,
Andy Shevchenko