linux-kernel - Re: [PATCH] taging: android: ashmem: Declared const key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200414095249.GE1163@kadam>
Date:   Tue, 14 Apr 2020 12:52:50 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     MugilRaj <dmugil2000@...il.com>
Cc:     mugil2301 <110117057@...t.edu>, devel@...verdev.osuosl.org,
        Todd Kjos <tkjos@...roid.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Arve Hjønnevåg <arve@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Martijn Coenen <maco@...roid.com>,
        Christian Brauner <christian@...uner.io>
Subject: Re: [PATCH] taging: android: ashmem: Declared const key

On Sun, Apr 12, 2020 at 12:59:56AM +0530, MugilRaj wrote:
> From: mugil2301 <110117057@...t.edu>
        ^^^^^^^^^
1) Real name.

2) Add a commit message.

> 
> Signed-off-by: mugil2301 <110117057@...t.edu>
                 ^^^^^^^^^
3) Real name here as well.

> ---
>  drivers/staging/android/ashmem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 8044510..50f882a 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
>  
>  static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
>  {
> -	static struct file_operations vmfile_fops;
> +	static const  struct file_operations vmfile_fops;
                    ^^
4) Too many space characters.

Please resend.

regards,
dan carpenter