linux-kernel - Re: [PATCH] drm: dpcd: Print more useful information during error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o8rumiqu.fsf@intel.com>
Date:   Tue, 14 Apr 2020 14:03:53 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Aurabindo Pillai <mail@...abindo.in>,
        maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
        airlied@...ux.ie, daniel@...ll.ch
Cc:     linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm: dpcd: Print more useful information during error

On Thu, 09 Apr 2020, Aurabindo Pillai <mail@...abindo.in> wrote:
> When DPCD access errors occur, knowing the register and request
> associated with the error helps debugging, so print the
> details in the debug message.
>
> Signed-off-by: Aurabindo Pillai <mail@...abindo.in>
> ---
>  drivers/gpu/drm/drm_dp_helper.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index a5364b519..545606aac 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -257,7 +257,9 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,
>  			err = ret;
>  	}
>  
> -	DRM_DEBUG_KMS("Too many retries, giving up. First error: %d\n", err);
> +	DRM_DEBUG_KMS("dpcd: Too many retries, giving up. First error: %d\t"
> +		      "address: %x\trequest: %x\t size:%zu\n",
> +		      err, msg.address, msg.request, msg.size);

Nitpicks, please don't add tabs, maybe use commas instead, and please
add 0x in front of hex.

BR,
Jani.


>  	ret = err;
>  
>  unlock:

-- 
Jani Nikula, Intel Open Source Graphics Center