[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200414121009.GA28866@Mani-XPS-13-9360>
Date: Tue, 14 Apr 2020 17:40:09 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Jonathan Cameron <jic23@...nel.org>
Cc: robh+dt@...nel.org, narcisaanamaria12@...il.com, knaack.h@....de,
lars@...afoo.de, pmeerw@...erw.net, linux-iio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: iio: chemical: Add binding for CCS811
VOC sensor
On Mon, Apr 13, 2020 at 05:53:23PM +0100, Jonathan Cameron wrote:
> On Mon, 13 Apr 2020 00:06:56 +0530
> mani@...nel.org wrote:
>
> > From: Manivannan Sadhasivam <mani@...nel.org>
> >
> > This commit adds devicetree binding for AMS CCS811 VOC sensor.
> >
> > Signed-off-by: Manivannan Sadhasivam <mani@...nel.org>
> Great to see this driver getting some more attention.
>
> A few things inline
>
> Thanks,
>
> Jonathan
>
> > ---
> > .../bindings/iio/chemical/ams,ccs811.yaml | 50 +++++++++++++++++++
> > 1 file changed, 50 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml b/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> > new file mode 100644
> > index 000000000000..564208af7b2b
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/chemical/ams,ccs811.yaml
> > @@ -0,0 +1,50 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> Preferred that all new binding docs are dual licensed with BSD as well
> to allow there use by things other than the kernel.
>
Okay will do.
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/chemical/ams,ccs811.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: AMS CCS811 VOC Sensor
> > +
> > +maintainers:
> > + - Narcisa Vasile <narcisaanamaria12@...il.com>
> > +
> > +description: |
> > + Ultra-Low Power Digital Gas Sensor for Monitoring Indoor Air Quality.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - ams,ccs811
> > + reg:
> > + maxItems: 1
> > +
> > + reset-gpios:
> > + description: GPIO connected to the nRESET line. This is an active low
> > + input to CCS811.
> > + maxItems: 1
> > +
> > + wakeup-gpios:
> > + description: GPIO connected to the nWAKE line. This is an active low
> > + input to CCS811.
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +examples:
> > + - |
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + ccs811@5b {
> Hmm. Not sure we have a generic name in the dt spec for voc sensor.
> Even so we should try for something appropriate.
>
> Could go with voc@5b?
>
Sounds good to me.
Thanks,
Mani
> > + compatible = "ams,ccs811";
> > + reg = <0x5b>;
> > + reset-gpios = <&gpioa 11 GPIO_ACTIVE_LOW>;
> > + wakeup-gpios = <&gpioa 12 GPIO_ACTIVE_LOW>;
> > + };
> > + };
> > +
> > +...
>
Powered by blists - more mailing lists