linux-kernel - Re: [PATCH v6 2/3] powerpc/powernv: Introduce support and parsing for self-save API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <cd07bd96-31af-1908-0584-5f4a0cead5f1@linux.ibm.com>
Date:   Tue, 14 Apr 2020 17:48:31 +0530
From:   Pratik Sampat <psampat@...ux.ibm.com>
To:     ego@...ux.vnet.ibm.com
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
        mpe@...erman.id.au, skiboot@...ts.ozlabs.org, oohall@...il.com,
        linuxram@...ibm.com, pratik.r.sampat@...il.com
Subject: Re: [PATCH v6 2/3] powerpc/powernv: Introduce support and parsing for
 self-save API

Hello Gautham,

[..snip..]

>> +
>> +			if (curr_spr.supported_mode & FIRMWARE_SELF_SAVE) {
>> +				rc = opal_slw_self_save_reg(pir,
>> +							curr_spr.spr);
>> +				if (rc != 0)
>> +					return rc;
>> +				switch (curr_spr.spr) {
>> +				case SPRN_LPCR:
>> +					is_lpcr_self_save = true;
> Could you consider converting is_lpcr_self_save and is_ptcr_self_save
> into static_keys ? For reference see commit
> 14c73bd344da("powerpc/vcpu: Assume dedicated processors as
> non-preempt")
>
Sure, using static keys is cleaner.

I'll also address the other nits mentioned in the e-mail earlier.

Thanks for the review.
Pratik