linux-kernel - Re: Re: [PATCH] ASoC: tas571x: disable regulators on failed probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200414122540.3367658-1-p.puschmann@pironex.de>
Date:   Tue, 14 Apr 2020 14:25:40 +0200
From:   Philipp Puschmann <p.puschmann@...onex.de>
To:     broonie@...nel.org
Cc:     alsa-devel@...a-project.org, cernekee@...omium.org,
        lgirdwood@...il.com, linux-kernel@...r.kernel.org,
        nhuck@...gle.com, p.puschmann@...onex.de, tglx@...utronix.de
Subject: Re: Re: [PATCH] ASoC: tas571x: disable regulators on failed probe

>> If probe fails after enabling the regulators regulator_put is called for
>> each supply without having them disabled before. This produces some
>> warnings like
>>=20
>> WARNING: CPU: 0 PID: 90 at drivers/regulator/core.c:2044 _regulator_put.part.0+0x154/0x15c
>> [<c010f7a8>] (unwind_backtrace) from [<c010c544>] (show_stack+0x10/0x14)
>> [<c010c544>] (show_stack) from [<c012b640>] (__warn+0xd0/0xf4)
>> [<c012b640>] (__warn) from [<c012b9b4>] (warn_slowpath_fmt+0x64/0xc4)
>> [<c012b9b4>] (warn_slowpath_fmt) from [<c04c4064>] (_regulator_put.part.0+0x154/0x15c)
>
>Please think hard before including complete backtraces in upstream
>reports, they are very large and contain almost no useful information
>relative to their size so often obscure the relevant content in your
>message. If part of the backtrace is usefully illustrative (it often is
>for search engines if nothing else) then it's usually better to pull out
>the relevant sections.

You are right. I will take care next time.

Regards,
Philipp