linux-kernel - Re: [PATCH] rtw88: avoid unused function warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200414124927.25401C44788@smtp.codeaurora.org>
Date:   Tue, 14 Apr 2020 12:49:27 +0000 (UTC)
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Yan-Hsuan Chuang <yhchuang@...ltek.com>,
        Chin-Yen Lee <timlee@...ltek.com>,
        Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Brian Norris <briannorris@...omium.org>,
        Chris Chiu <chiu@...lessm.com>,
        Jian-Hong Pan <jian-hong@...lessm.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtw88: avoid unused function warnings

Arnd Bergmann <arnd@...db.de> wrote:

> The rtw88 driver defines emtpy functions with multiple indirections
> but gets one of these wrong:
> 
> drivers/net/wireless/realtek/rtw88/pci.c:1347:12: error: 'rtw_pci_resume' defined but not used [-Werror=unused-function]
>  1347 | static int rtw_pci_resume(struct device *dev)
>       |            ^~~~~~~~~~~~~~
> drivers/net/wireless/realtek/rtw88/pci.c:1342:12: error: 'rtw_pci_suspend' defined but not used [-Werror=unused-function]
>  1342 | static int rtw_pci_suspend(struct device *dev)
> 
> Better simplify it to rely on the conditional reference in
> SIMPLE_DEV_PM_OPS(), and mark the functions as __maybe_unused to avoid
> warning about it.
> 
> I'm not sure if these are needed at all given that the functions
> don't do anything, but they were only recently added.
> 
> Fixes: 44bc17f7f5b3 ("rtw88: support wowlan feature for 8822c")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Patch applied to wireless-drivers.git, thanks.

7dc7c41607d1 rtw88: avoid unused function warnings

-- 
https://patchwork.kernel.org/patch/11480657/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches