linux-kernel - Re: [PATCH net 2/4] net: dsa: b53: Fix valid setting for MDB entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200414140641.GK436020@lunn.ch>
Date:   Tue, 14 Apr 2020 16:06:41 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        open list <linux-kernel@...r.kernel.org>, davem@...emloft.net,
        kuba@...nel.org
Subject: Re: [PATCH net 2/4] net: dsa: b53: Fix valid setting for MDB entries

On Mon, Apr 13, 2020 at 09:16:28PM -0700, Florian Fainelli wrote:
> When support for the MDB entries was added, the valid bit was correctly
> changed to be assigned depending on the remaining port bitmask, that is,
> if there were no more ports added to the entry's port bitmask, the entry
> now becomes invalid. There was another assignment a few lines below that
> would override this which would invalidate entries even when there were
> still multiple ports left in the MDB entry.
> 
> Fixes: 5d65b64a3d97 ("net: dsa: b53: Add support for MDB")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew