linux-kernel - Re: [PATCH net 4/4] net: dsa: b53: Rework ARL bin logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200414141611.GM436020@lunn.ch>
Date:   Tue, 14 Apr 2020 16:16:11 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        open list <linux-kernel@...r.kernel.org>, davem@...emloft.net,
        kuba@...nel.org
Subject: Re: [PATCH net 4/4] net: dsa: b53: Rework ARL bin logic

On Mon, Apr 13, 2020 at 09:16:30PM -0700, Florian Fainelli wrote:
> When asking the ARL to read a MAC address, we will get a number of bins
> returned in a single read. Out of those bins, there can essentially be 3
> states:
> 
> - all bins are full, we have no space left, and we can either replace an
>   existing address or return that full condition
> 
> - the MAC address was found, then we need to return its bin index and
>   modify that one, and only that one
> 
> - the MAC address was not found and we have a least one bin free, we use
>   that bin index location then
> 
> The code would unfortunately fail on all counts.
> 
> Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew