linux-kernel - Re: [RFC PATCH v2 11/12] documentation: Add IPE Documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200414093809.2c6ef93b@lwn.net>
Date:   Tue, 14 Apr 2020 09:38:09 -0600
From:   Jonathan Corbet <corbet@....net>
To:     deven.desai@...ux.microsoft.com
Cc:     agk@...hat.com, axboe@...nel.dk, snitzer@...hat.com,
        jmorris@...ei.org, serge@...lyn.com, zohar@...ux.ibm.com,
        linux-integrity@...r.kernel.org,
        linux-security-module@...r.kernel.org, dm-devel@...hat.com,
        linux-block@...r.kernel.org, tyhicks@...ux.microsoft.com,
        pasha.tatashin@...een.com, sashal@...nel.org,
        jaskarankhurana@...ux.microsoft.com, nramas@...ux.microsoft.com,
        mdsakib@...ux.microsoft.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 11/12] documentation: Add IPE Documentation

On Mon,  6 Apr 2020 15:14:38 -0700
deven.desai@...ux.microsoft.com wrote:

> From: Deven Bowers <deven.desai@...ux.microsoft.com>
> 
> Add IPE's documentation to the kernel tree.
> 
> Signed-off-by: Deven Bowers <deven.desai@...ux.microsoft.com>

Thanks for including this nice documentation from the outset!  I have a
couple of tiny nits to pick, but nothing really substantive to complain
about, so:

  Acked-by: Jonathan Corbet <corbet@....net>

[...]

> +IPE is a Linux Security Module, which allows for a configurable policy

I'd drop the comma (I told you these were nits!)

[...]

> +IPE Policy
> +~~~~~~~~~~
> +
> +IPE policy is designed to be both forward compatible and backwards
> +compatible. There is one required line, at the top of the policy,
> +indicating the policy name, and the policy version, for instance:
> +
> +::
> +
> +   policy_name="Ex Policy" policy_version=0.0.0

This pattern can be compressed a bit by just putting the "::" at the end of
the last line of text:

	indicating the policy name, and the policy version, for instance::

	   policy_name="Ex Policy" policy_version=0.0.0

The result is a bit more readable in the plain-text format, IMO, and
renders exactly the same in Sphinx.

Thanks,

jon