linux-kernel - Re: [RFC PATCH v2 0/3] Add new reg_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADBw62p7Z9tLYknc6Jev5dhSrbDpJ_Lr8w8-dC0DG-3gYsMcMw@mail.gmail.com>
Date:   Wed, 15 Apr 2020 20:59:20 +0800
From:   Baolin Wang <baolin.wang7@...il.com>
To:     Lee Jones <lee.jones@...aro.org>, Arnd Bergmann <arnd@...db.de>,
        Mark Brown <broonie@...nel.org>
Cc:     Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2 0/3] Add new reg_update_bits() support

Hi Arnd,

On Mon, Apr 13, 2020 at 2:13 PM Baolin Wang <baolin.wang7@...il.com> wrote:
>
> The Spreadtrum platform uses a special set/clear method to update
> registers' bits, thus this patch set registers a physical regmap
> bus into syscon core to support this feature instead of using the
> MMIO bus, which is not a physical regmap bus.
>
> Any comments are welcome. Thanks.

I saw Mark had applied patch 2 already. Thanks Mark.

How do you think the syscon changes? As Mark pointed out, we can not
add update_bits() for MMIO regmap bus, which is not a real physical
regmap bus, so I introduced a new helper to allow a  physical regmap
bus to be registered.

And I wonder if you can apply the SPRD SoC driver through your tree if
no objections from your side? Thanks.

> Changes from RFC v1:
>  - Add new helper to registers a physical regmap bus instead of
>  using the MMIO bus.
>
> Baolin Wang (3):
>   mfd: syscon: Support physical regmap bus
>   regmap: Add bus reg_update_bits() support
>   soc: sprd: Add Spreadtrum special bits updating support
>
>  drivers/base/regmap/regmap.c   |  1 +
>  drivers/mfd/syscon.c           | 16 ++++++-
>  drivers/soc/Kconfig            |  1 +
>  drivers/soc/Makefile           |  1 +
>  drivers/soc/sprd/Kconfig       | 16 +++++++
>  drivers/soc/sprd/Makefile      |  2 +
>  drivers/soc/sprd/sprd_syscon.c | 76 ++++++++++++++++++++++++++++++++++
>  include/linux/mfd/syscon.h     |  7 ++++
>  8 files changed, 118 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/soc/sprd/Kconfig
>  create mode 100644 drivers/soc/sprd/Makefile
>  create mode 100644 drivers/soc/sprd/sprd_syscon.c
>
> --
> 2.17.1
>


-- 
Baolin Wang