linux-kernel - [PATCH v2] media: Kconfig: include test_drivers with MEDIA_TEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 15 Apr 2020 14:35:52 +0100
From:   Guillaume Tucker <guillaume.tucker@...labora.com>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     kernel@...labora.com, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH v2] media: Kconfig: include test_drivers with MEDIA_TEST_SUPPORT

Include test_drivers/Kconfig when MEDIA_TEST_SUPPORT is enabled rather
than MEDIA_PLATFORM_SUPPORT.  Test drivers should not depend on
platform drivers to be enabled.

Reported-by: "kernelci.org bot" <bot@...nelci.org>
Fixes: 4b32216adb010 ("media: split test drivers from platform directory")
Signed-off-by: Guillaume Tucker <guillaume.tucker@...labora.com>
---

Notes:
    v2: Drop redundant "if MEDIA_TEST_SUPPORT" in test_drivers/Kconfig

 drivers/media/Kconfig              | 5 ++++-
 drivers/media/test_drivers/Kconfig | 4 ----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index a8def1591352..d926c2603de2 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -238,10 +238,13 @@ source "drivers/media/common/Kconfig"
 
 if MEDIA_PLATFORM_SUPPORT
 source "drivers/media/platform/Kconfig"
-source "drivers/media/test_drivers/Kconfig"
 source "drivers/media/mmc/Kconfig"
 endif
 
+if MEDIA_TEST_SUPPORT
+source "drivers/media/test_drivers/Kconfig"
+endif
+
 source "drivers/media/firewire/Kconfig"
 
 endmenu
diff --git a/drivers/media/test_drivers/Kconfig b/drivers/media/test_drivers/Kconfig
index 9f4a9cfbacc9..e62abec030c3 100644
--- a/drivers/media/test_drivers/Kconfig
+++ b/drivers/media/test_drivers/Kconfig
@@ -1,7 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
 
-if MEDIA_TEST_SUPPORT
-
 menuconfig V4L_TEST_DRIVERS
 	bool "V4L test drivers"
 	depends on VIDEO_DEV
@@ -24,5 +22,3 @@ config VIDEO_VIM2M
 source "drivers/media/test_drivers/vicodec/Kconfig"
 
 endif #V4L_TEST_DRIVERS
-
-endif #MEDIA_TEST_SUPPORT
-- 
2.20.1