linux-kernel - RE: [PATCH v7 00/13] add ecspi ERR009165 for i.mx6/7 soc family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <VE1PR04MB6638479E728795FA28F7614A89DB0@VE1PR04MB6638.eurprd04.prod.outlook.com>
Date:   Wed, 15 Apr 2020 14:06:11 +0000
From:   Robin Gong <yibin.gong@....com>
To:     "Fuzzey, Martin" <martin.fuzzey@...wbird.group>
CC:     Sascha Hauer <s.hauer@...gutronix.de>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>, Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Fabio Estevam <festevam@...il.com>,
        "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH v7 00/13] add ecspi ERR009165 for i.mx6/7 soc family

On 2020/04/15 17:47 Fuzzey, Martin <martin.fuzzey@...wbird.group> wrote:d
> Hi Robin,
> 
> 
> On Wed, 11 Mar 2020 at 09:35, Robin Gong <yibin.gong@....com> wrote:
> >
> > There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO
> > transfer to be send twice in DMA mode. Please get more information from:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.
> >
> nxp.com%2Fdocs%2Fen%2Ferrata%2FIMX6DQCE.pdf&amp;data=02%7C01%7C
> yibin.g
> >
> ong%40nxp.com%7Caf3ad866d3274fce2aaf08d7e121ffb8%7C686ea1d3bc2b4c
> 6fa92
> >
> cd99c5c301635%7C0%7C1%7C637225408450989272&amp;sdata=av3%2FnSaP
> pQ6rHlkmFAooZS6P8fnxC%2Bm7sJrBg30dUZs%3D&amp;reserved=0. The
> workaround is adding new sdma ram script which works in XCH  mode as PIO
> inside sdma instead of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0.
> The issue should be exist on all legacy i.mx6/7 soc family before i.mx6ul.
> > NXP fix this design issue from i.mx6ul, so newer chips including
> > i.mx6ul/ 6ull/6sll do not need this workaroud anymore. All other
> > i.mx6/7/8 chips still need this workaroud. This patch set add new
> 'fsl,imx6ul-ecspi'
> > for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need
> > errata or not.
> > The first two reverted patches should be the same issue, though, it
> > seems 'fixed' by changing to other shp script. Hope Sean or Sascha
> > could have the chance to test this patch set if could fix their issues.
> > Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work
> > on i.mx8mm because the event id is zero.
> >
> > PS:
> >    Please get sdma firmware from below linux-firmware and copy it to
> > your local rootfs /lib/firmware/imx/sdma.
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.
> >
> kernel.org%2Fpub%2Fscm%2Flinux%2Fkernel%2Fgit%2Ffirmware%2Flinux-firm
> w
> >
> are.git%2Ftree%2Fimx%2Fsdma&amp;data=02%7C01%7Cyibin.gong%40nxp.co
> m%7C
> >
> af3ad866d3274fce2aaf08d7e121ffb8%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C
> >
> 0%7C1%7C637225408450999264&amp;sdata=%2BgcoGJqUKAkZbc%2BXgtXPsp
> d6X7p0G
> > Ds7ndyHY4i1wp0%3D&amp;reserved=0
> >
> 
> A couple of questions
> 
> 1) Is this series needed for the i.MX6DL? (the document you linked only seems
> to mention i.MX6D/Q
Yes, it's needed for all i.mx6 legacy chips include i.MX6DL since they share the same ecspi IP. Show the i.MX6D/Q document as a sample.
> 2) If the laterst SDMA firmware mentionned above is used will this break
> systems running mainline kernels without this patch series applied?
No basic function broken with the latest SDMA firmware and mainline kernel without this patch series, but the ecspi issue ERR009165 is still here then.