[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200415142959.25673-1-ilie.halip@gmail.com>
Date: Wed, 15 Apr 2020 17:29:58 +0300
From: Ilie Halip <ilie.halip@...il.com>
To: linux-riscv@...ts.infradead.org
Cc: Fangrui Song <maskray@...gle.com>,
Jordan Rupprecht <rupprecht@...gle.com>,
Ilie Halip <ilie.halip@...il.com>,
Paul Walmsley <paul.walmsley@...ive.com>,
Palmer Dabbelt <palmer@...belt.com>,
Albert Ou <aou@...s.berkeley.edu>,
Nick Desaulniers <ndesaulniers@...gle.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Thomas Gleixner <tglx@...utronix.de>,
Mao Han <han_mao@...ky.com>, linux-kernel@...r.kernel.org,
clang-built-linux@...glegroups.com
Subject: [PATCH v2] riscv: fix vdso build with lld
When building with the LLVM linker this error occurrs:
LD arch/riscv/kernel/vdso/vdso-syms.o
ld.lld: error: no input files
This happens because the lld treats -R as an alias to -rpath, as opposed
to ld where -R means --just-symbols.
Use the long option name for compatibility between the two.
Link: https://github.com/ClangBuiltLinux/linux/issues/805
Reported-by: Dmitry Golovin <dima@...ovin.in>
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>
Signed-off-by: Ilie Halip <ilie.halip@...il.com>
---
Changed in v2:
* a comment line dropped, another one slightly reworded
* added Nick's Reviewed-by
---
arch/riscv/kernel/vdso/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile
index 33b16f4212f7..a4ee3a0e7d20 100644
--- a/arch/riscv/kernel/vdso/Makefile
+++ b/arch/riscv/kernel/vdso/Makefile
@@ -33,15 +33,15 @@ $(obj)/vdso.so.dbg: $(src)/vdso.lds $(obj-vdso) FORCE
$(call if_changed,vdsold)
# We also create a special relocatable object that should mirror the symbol
-# table and layout of the linked DSO. With ld -R we can then refer to
-# these symbols in the kernel code rather than hand-coded addresses.
+# table and layout of the linked DSO. With ld --just-symbols we can then
+# refer to these symbols in the kernel code rather than hand-coded addresses.
SYSCFLAGS_vdso.so.dbg = -shared -s -Wl,-soname=linux-vdso.so.1 \
-Wl,--build-id -Wl,--hash-style=both
$(obj)/vdso-dummy.o: $(src)/vdso.lds $(obj)/rt_sigreturn.o FORCE
$(call if_changed,vdsold)
-LDFLAGS_vdso-syms.o := -r -R
+LDFLAGS_vdso-syms.o := -r --just-symbols
$(obj)/vdso-syms.o: $(obj)/vdso-dummy.o FORCE
$(call if_changed,ld)
--
2.17.1
Powered by blists - more mailing lists