linux-kernel - Re: [PATCH] KVM: SVM: Fix build error due to missing release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <26c86223-6e5b-169b-7967-a406a3b1678b@redhat.com>
Date:   Wed, 15 Apr 2020 16:53:52 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Borislav Petkov <bp@...en8.de>, Joerg Roedel <joro@...tes.org>
Cc:     KVM <kvm@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] KVM: SVM: Fix build error due to missing release_pages()
 include

On 11/04/20 18:09, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> Fix:
> 
>   arch/x86/kvm/svm/sev.c: In function ‘sev_pin_memory’:
>   arch/x86/kvm/svm/sev.c:360:3: error: implicit declaration of function ‘release_pages’;\
> 	  did you mean ‘reclaim_pages’? [-Werror=implicit-function-declaration]
>     360 |   release_pages(pages, npinned);
>         |   ^~~~~~~~~~~~~
>         |   reclaim_pages
> 
> because svm.c includes pagemap.h but the carved out sev.c needs it too.
> Triggered by a randconfig build.
> 
> Fixes: eaf78265a4ab ("KVM: SVM: Move SEV code to separate file")
> Signed-off-by: Borislav Petkov <bp@...e.de>
> ---
>  arch/x86/kvm/svm/sev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c
> index 0e3fc311d7da..0208ab2179d5 100644
> --- a/arch/x86/kvm/svm/sev.c
> +++ b/arch/x86/kvm/svm/sev.c
> @@ -12,6 +12,7 @@
>  #include <linux/kernel.h>
>  #include <linux/highmem.h>
>  #include <linux/psp-sev.h>
> +#include <linux/pagemap.h>
>  #include <linux/swap.h>
>  
>  #include "x86.h"
> 

Queued, thanks.

Paolo