lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Apr 2020 12:06:55 -0400 From: Paul Moore <paul@...l-moore.com> To: Richard Guy Briggs <rgb@...hat.com> Cc: Joel Fernandes <joel@...lfernandes.org>, Shuah Khan <skhan@...uxfoundation.org>, linux-audit@...hat.com, linux-kernel-mentees@...ts.linuxfoundation.org, linux-kernel@...r.kernel.org, Amol Grover <frextrite@...il.com> Subject: Re: [PATCH v2] kernel: audit.c: Add __rcu notation to RCU pointer On Wed, Apr 15, 2020 at 11:34 AM Richard Guy Briggs <rgb@...hat.com> wrote: > On 2019-11-29 21:07, Joel Fernandes wrote: > > On Thu, Nov 28, 2019 at 09:02:03PM +0530, Amol Grover wrote: > > > add __rcu notation to RCU protected global pointer auditd_conn > > > > Again, please use proper punctuation and captilization. This is unacceptable. > > Please put more effort into changelog. > > > > Otherwise the patch diff itself looks good to me, with the above nit > > corrected, you could add my tag to the next revision: > > > > Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org> > > > > thanks, > > > > - Joel > > > > > > > > Fixes multiple instances of sparse error: > > > error: incompatible types in comparison expression > > > (different address spaces) > > Amol or Joel: Is there a reproducer recipe for this? The commit which was merged has a slightly better description which may help. commit cb5172d96d16df72db8b55146b0ec00bfd97f079 Author: Amol Grover <frextrite@...il.com> Date: Mon Dec 2 00:03:48 2019 +0530 audit: Add __rcu annotation to RCU pointer Add __rcu annotation to RCU-protected global pointer auditd_conn. auditd_conn is an RCU-protected global pointer,i.e., accessed via RCU methods rcu_dereference() and rcu_assign_pointer(), hence it must be annotated with __rcu for sparse to report warnings/errors correctly. Fix multiple instances of the sparse error: error: incompatible types in comparison expression (different address spaces) Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org> Signed-off-by: Amol Grover <frextrite@...il.com> [PM: tweak subject line] Signed-off-by: Paul Moore <paul@...l-moore.com> -- paul moore www.paul-moore.com
Powered by blists - more mailing lists