linux-kernel - RE: [PATCH] ACPICA: make acpi_protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 15 Apr 2020 16:09:15 +0000
From:   "Kaneda, Erik" <erik.kaneda@...el.com>
To:     Jason Yan <yanaijie@...wei.com>,
        "Moore, Robert" <robert.moore@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Hulk Robot <hulkci@...wei.com>
Subject: RE: [PATCH] ACPICA: make acpi_protocol_lengths static



> -----Original Message-----
> From: Jason Yan <yanaijie@...wei.com>
> Sent: Wednesday, April 15, 2020 1:50 AM
> To: Moore, Robert <robert.moore@...el.com>; Kaneda, Erik
> <erik.kaneda@...el.com>; Wysocki, Rafael J <rafael.j.wysocki@...el.com>;
> lenb@...nel.org; linux-acpi@...r.kernel.org; devel@...ica.org; linux-
> kernel@...r.kernel.org
> Cc: Jason Yan <yanaijie@...wei.com>; Hulk Robot <hulkci@...wei.com>
> Subject: [PATCH] ACPICA: make acpi_protocol_lengths static
> 
> Fix the following sparse warning:
> 
> drivers/acpi/acpica/exfield.c:25:10: warning: symbol 'acpi_protocol_lengths'
> was not declared. Should it be static?

This has already been reported and I've made the appropriate fix in the ACPICA code base already. it should be available in the next ACPICA release

Thanks,
Erik
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/acpi/acpica/exfield.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.c index
> e85eb31e5075..3323a2ba6a31 100644
> --- a/drivers/acpi/acpica/exfield.c
> +++ b/drivers/acpi/acpica/exfield.c
> @@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
>   */
>  #define ACPI_INVALID_PROTOCOL_ID        0x80
>  #define ACPI_MAX_PROTOCOL_ID            0x0F
> -const u8 acpi_protocol_lengths[] = {
> +static const u8 acpi_protocol_lengths[] = {
>  	ACPI_INVALID_PROTOCOL_ID,	/* 0 - reserved */
>  	ACPI_INVALID_PROTOCOL_ID,	/* 1 - reserved */
>  	0x00,			/* 2 - ATTRIB_QUICK */
> --
> 2.21.1