[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200415161739.GA72691@vkoul-mobl>
Date: Wed, 15 Apr 2020 21:47:39 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc: dmaengine@...r.kernel.org,
Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: uniphier-xdmac: switch to single reg
region
On 01-04-20, 12:21, Masahiro Yamada wrote:
> The reg in the example "<0x5fc10000 0x1000>, <0x5fc20000 0x800>"
> is wrong. The register region of this controller is much smaller,
> and there is no other hardware register interleaved. There is no
> good reason to split it into two regions.
>
> Just use a single, contiguous register region.
>
> While I am here, I made the 'dma-channels' property mandatory because
> otherwise there is no way to determine the number of the channels.
>
> Please note the original binding was merged recently. Since there
> is no user yet, this change has no actual impact.
Applied, thanks
--
~Vinod
Powered by blists - more mailing lists