[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200415182037.521a92b2.cohuck@redhat.com>
Date: Wed, 15 Apr 2020 18:20:37 +0200
From: Cornelia Huck <cohuck@...hat.com>
To: Emanuele Giuseppe Esposito <eesposit@...hat.com>
Cc: kvm@...r.kernel.org,
Philippe Mathieu-Daudé <f4bug@...at.org>,
Marc Zyngier <maz@...nel.org>,
James Morse <james.morse@....com>,
Julien Thierry <julien.thierry.kdev@...il.com>,
Suzuki K Poulose <suzuki.poulose@....com>,
Paul Mackerras <paulus@...abs.org>,
Christian Borntraeger <borntraeger@...ibm.com>,
Janosch Frank <frankja@...ux.ibm.com>,
David Hildenbrand <david@...hat.com>,
Paolo Bonzini <pbonzini@...hat.com>,
Sean Christopherson <sean.j.christopherson@...el.com>,
Vitaly Kuznetsov <vkuznets@...hat.com>,
Wanpeng Li <wanpengli@...cent.com>,
Jim Mattson <jmattson@...gle.com>,
Joerg Roedel <joro@...tes.org>,
linux-arm-kernel@...ts.infradead.org, kvmarm@...ts.cs.columbia.edu,
linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
kvm-ppc@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH v2] kvm_host: unify VM_STAT and VCPU_STAT definitions in
a single place
On Tue, 14 Apr 2020 17:56:25 +0200
Emanuele Giuseppe Esposito <eesposit@...hat.com> wrote:
> The macros VM_STAT and VCPU_STAT are redundantly implemented in multiple
> files, each used by a different architecure to initialize the debugfs
> entries for statistics. Since they all have the same purpose, they can be
> unified in a single common definition in include/linux/kvm_host.h
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@...hat.com>
> ---
> arch/arm64/kvm/guest.c | 23 ++---
> arch/mips/kvm/mips.c | 61 ++++++------
> arch/powerpc/kvm/book3s.c | 61 ++++++------
> arch/powerpc/kvm/booke.c | 41 ++++----
> arch/s390/kvm/kvm-s390.c | 203 +++++++++++++++++++-------------------
> arch/x86/kvm/x86.c | 80 +++++++--------
> include/linux/kvm_host.h | 5 +
> 7 files changed, 231 insertions(+), 243 deletions(-)
Adds a bit of churn, but the end result does look nicer. Looks sane,
but did not review in detail.
Acked-by: Cornelia Huck <cohuck@...hat.com>
Powered by blists - more mailing lists