linux-kernel - Re: [PATCH] regulator: use consumer->supply_name in debugfs/regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <606b7ddd-0c9b-2ba1-f873-8507377fdc4e@gmail.com>
Date:   Wed, 15 Apr 2020 19:28:09 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: use consumer->supply_name in
 debugfs/regulator_summary

04.04.2020 03:11, Michał Mirosław пишет:
> Make it easier to identify regulator consumers when consumer device
> uses more than one supply.
> 
> Before:
> 
>   regulator                      ena use open bypass voltage current min     max
>  -----------------------------------------------------------------------------------
>   regulator-dummy                  1   0    2      0     0mV     0mA 0mV     0mV
>      1-0010                                                          0mV     0mV
>      1-0010                                                          0mV     0mV
> 
> After:
> 
>   regulator                      ena use open bypass voltage current min     max
>  -----------------------------------------------------------------------------------
>   regulator-dummy                  1   0    2      0     0mV     0mA 0mV     0mV
>      1-0010-vccio                                                    0mV     0mV
>      1-0010-vcc33                                                    0mV     0mV
> 
> Signed-off-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>
> ---
>  drivers/regulator/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index c340505150b6..ad143004c32b 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -5496,6 +5496,7 @@ static void regulator_summary_show_subtree(struct seq_file *s,
>  		seq_printf(s, "%*s%-*s ",
>  			   (level + 1) * 3 + 1, "",
>  			   30 - (level + 1) * 3,
> +			   consumer->supply_name ? consumer->supply_name :
>  			   consumer->dev ? dev_name(consumer->dev) : "deviceless");
>  
>  		switch (rdev->desc->type) {
> 

Hello Michał,

This is a very nice improvement, I like it!

Reviewed-by: Dmitry Osipenko <digetx@...il.com>
Tested-by: Dmitry Osipenko <digetx@...il.com>