linux-kernel - Re: [PATCH v2 6/6] Input: snvs_pwrkey - only IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad07da3c-19c4-67cd-b819-63cf3746caf6@nxp.com>
Date:   Wed, 15 Apr 2020 19:57:36 +0300
From:   Horia Geantă <horia.geanta@....com>
To:     Adam Ford <aford173@...il.com>,
        André Draszik <git@...red.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Robin Gong <yibin.gong@....com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Aymen Sghaier <aymen.sghaier@....com>,
        Anson Huang <anson.huang@....com>,
        Fabio Estevam <festevam@...il.com>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Rob Herring <robh+dt@...nel.org>,
        dl-linux-imx <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>
Subject: Re: [PATCH v2 6/6] Input: snvs_pwrkey - only IRQ_HANDLED for our own
 events

Hi Herbert, Dmitry,

On 4/1/2020 11:58 AM, Horia Geanta wrote:
> On 3/28/2020 5:43 AM, Adam Ford wrote:
>> On Mon, Mar 2, 2020 at 3:22 AM Horia Geanta <horia.geanta@....com> wrote:
>>>
>>> On 2/25/2020 6:12 PM, André Draszik wrote:
>>>> The snvs_pwrkey shares the SNVS LPSR status register with the snvs_rtc.
>>>>
>>>> This driver here should only return IRQ_HANDLED if the status register
>>>> indicates that the event we're handling in the irq handler was genuinely
>>>> intended for this driver. Otheriwse the interrupt subsystem will
>>>> assume the interrupt was handled successfully even though it wasn't
>>>> at all.
>>>>
>>>> Signed-off-by: André Draszik <git@...red.net>
>>>> Cc: "Horia Geantă" <horia.geanta@....com>
>>>> Cc: Aymen Sghaier <aymen.sghaier@....com>
>>>> Cc: Herbert Xu <herbert@...dor.apana.org.au>
>>>> Cc: "David S. Miller" <davem@...emloft.net>
>>>> Cc: Rob Herring <robh+dt@...nel.org>
>>>> Cc: Mark Rutland <mark.rutland@....com>
>>>> Cc: Shawn Guo <shawnguo@...nel.org>
>>>> Cc: Sascha Hauer <s.hauer@...gutronix.de>
>>>> Cc: Pengutronix Kernel Team <kernel@...gutronix.de>
>>>> Cc: Fabio Estevam <festevam@...il.com>
>>>> Cc: NXP Linux Team <linux-imx@....com>
>>>> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
>>>> Cc: Anson Huang <Anson.Huang@....com>
>>>> Cc: Robin Gong <yibin.gong@....com>
>>>> Cc: linux-crypto@...r.kernel.org
>>>> Cc: devicetree@...r.kernel.org
>>>> Cc: linux-arm-kernel@...ts.infradead.org
>>>> Cc: linux-input@...r.kernel.org
>>> For patches 2-6:
>>> Reviewed-by: Horia Geantă <horia.geanta@....com>
>>>
>>> Also imx8mn.dtsi and imx8mp.dtsi will have to be updated.
>>
>> Is there an update coming for the 8mn family?  I am seeing it not wake
>> from the power key, and I was hoping to resolve that before i make a
>> push to submit a new 8MN board for review.
>>
> Starting with linux-next next-20200320, there's commit
> arm64: dts: imx8mn: Add snvs clock to powerkey
> 
> Could you confirm you've tested with a tree including it?
> 
Seems that from this series:
https://lore.kernel.org/linux-crypto/20200225161201.1975-5-git@andred.net/T/
only DT patches (2,3,4) were applied.

Would it be ok to go via crypto tree with:
[PATCH v2 1/6] dt-bindings: crypto: fsl-sec4: add snvs clock to pwrkey

and via input tree with:
[PATCH v2 5/6] Input: snvs_pwrkey - enable snvs clock as needed
[PATCH v2 6/6] Input: snvs_pwrkey - only IRQ_HANDLED for our own events
?

Thanks,
Horia