linux-kernel - RE: [tip: ras/core] x86/mce: Add a struct mce.kflags field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F7F5E6485@ORSMSX115.amr.corp.intel.com>
Date:   Wed, 15 Apr 2020 18:19:47 +0000
From:   "Luck, Tony" <tony.luck@...el.com>
To:     Borislav Petkov <bp@...e.de>
CC:     x86 <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [tip: ras/core] x86/mce: Add a struct mce.kflags field

> diff --git a/arch/x86/include/uapi/asm/mce.h b/arch/x86/include/uapi/asm/mce.h
> index 955c2a2..5b59d80 100644
> --- a/arch/x86/include/uapi/asm/mce.h
> +++ b/arch/x86/include/uapi/asm/mce.h
> @@ -35,6 +35,7 @@ struct mce {
> 	__u64 ipid;		/* MCA_IPID MSR: only valid on SMCA systems */
> 	__u64 ppin;		/* Protected Processor Inventory Number */
> 	__u32 microcode;	/* Microcode revision */
> +	__u64 kflags;		/* Internal kernel use. See below */
 > };
 
Minor nit. You moved the #defines for the kflags bits to internal.h (which
was a good thing), but left the "See below" comment here.

-Tony