linux-kernel - Re: [PATCH] soc: qcom: cmd-db: Add debugfs dumping file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <158697856675.105027.14667274133002675067@swboyd.mtv.corp.google.com>
Date:   Wed, 15 Apr 2020 12:22:46 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Lina Iyer <ilina@...eaurora.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Maulik Shah <mkshah@...eaurora.org>
Subject: Re: [PATCH] soc: qcom: cmd-db: Add debugfs dumping file

Quoting Lina Iyer (2020-04-15 07:17:54)
> On Tue, Apr 14 2020 at 00:30 -0600, Stephen Boyd wrote:
> >Quoting Lina Iyer (2020-04-14 14:50:15)
> >> On Mon, Mar 09 2020 at 12:57 -0600, Stephen Boyd wrote:
> >> >+              seq_puts(seq, "-------------------------\n");
> >> >+
> >> >+              ent = rsc_to_entry_header(rsc);
> >> >+              for (j = 0; j < le16_to_cpu(rsc->cnt); j++, ent++) {
> >> >+                      seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
> >> 0x%05x is what we would have for a resource address.
> >
> >Sorry I totally missed this because the mail wasn't trimmed at all and
> >it was really hard to find the one line that wasn't quoted!
> >
> Sorry, my bad. Somehow didn't notice the quoting has changed.
> 
> >5 vs. 8 sounds OK to me. Send a patch? Or I can do it if you prefer.
> Apart from the nit, I think the patch looks good. Feel free to add -
> 
> Reviewed-by: Lina Iyer <ilina@...eaurora.org>
> Tested-by: Lina Iyer <ilina@...eaurora.org>

Cool thanks. I'll send a patch given that Bjorn has already picked it
into the qcom tree.