linux-kernel - Re: [PATCH v3 3/3] x86/delay: Introduce TPAUSE delay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c044d6001cf4ad25a8d13ba64c1d891721c16abd.camel@intel.com>
Date:   Wed, 15 Apr 2020 12:57:16 -0700
From:   km <kyung.min.park@...el.com>
To:     Peter Zijlstra <peterz@...radead.org>,
        "Luck, Tony" <tony.luck@...el.com>
Cc:     "x86@...nel.org" <x86@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "hpa@...or.com" <hpa@...or.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "ak@...ux.intel.com" <ak@...ux.intel.com>,
        "Raj, Ashok" <ashok.raj@...el.com>,
        "Shankar, Ravi V" <ravi.v.shankar@...el.com>,
        "Yu, Fenghua" <fenghua.yu@...el.com>
Subject: Re: [PATCH v3 3/3] x86/delay: Introduce TPAUSE delay

Hi Peter,

On Tue, 2020-04-14 at 20:05 +0200, Peter Zijlstra wrote:
> On Tue, Apr 14, 2020 at 06:00:21PM +0000, Luck, Tony wrote:
> > > > +static inline void __tpause(u32 ecx, u32 edx, u32 eax)
> > > > +{
> > > > +	/* "tpause %ecx, %edx, %eax;" */
> > > > +	asm volatile(".byte 0x66, 0x0f, 0xae, 0xf1\t\n"
> > > > +		     :
> > > > +		     : "c"(ecx), "d"(edx), "a"(eax));
> > > > +}
> > > 
> > > Can we please get a comment stating from what binutils version
> > > this
> > > opcode has a mnemonic? That way, when we raise the minimum
> > > binutils
> > > version we can easily grep and find such things.
> > 
> > Or maybe use arch/x86/Kconfig.assembler to set up a
> > CONFIG_AS_TPAUSE?
> > 
> > Then the code can read something like (syntax may need fixing)
> > 
> > #ifdef CONFIG_AS_TPAUSE
> > 		asm volatile("tpause %ecx\n", : : "c"(ecx), "d"(edx),
> > "a"(eax));
> > #else
> > 		asm volatile(".byte hex gibberish ...
> > #endif
> 
> Then we still need a comment to know when we can kill that...

Thanks. I'll update in next patch.