linux-kernel - Re: [PATCH] x86/kvm: make steal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202004160431.KSp9SkA3%lkp@intel.com>
Date:   Thu, 16 Apr 2020 04:29:47 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Jason Yan <yanaijie@...wei.com>, pbonzini@...hat.com,
        sean.j.christopherson@...el.com, vkuznets@...hat.com,
        wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org,
        hpa@...or.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Cc:     kbuild-all@...ts.01.org, Jason Yan <yanaijie@...wei.com>
Subject: Re: [PATCH] x86/kvm: make steal_time static

Hi Jason,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on kvm/linux-next]
[also build test WARNING on v5.7-rc1 next-20200415]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Jason-Yan/x86-kvm-make-steal_time-static/20200416-010910
base:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next
config: i386-debian-10.3 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/asm-generic/percpu.h:7:0,
                    from arch/x86/include/asm/percpu.h:556,
                    from arch/x86/include/asm/current.h:6,
                    from include/linux/sched.h:12,
                    from include/linux/context_tracking.h:5,
                    from arch/x86/kernel/kvm.c:10:
>> arch/x86/kernel/kvm.c:58:40: warning: '__externally_visible__' attribute have effect only on public objects [-Wattributes]
    static DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible;
                                           ^
   include/linux/percpu-defs.h:104:31: note: in definition of macro 'DEFINE_PER_CPU_SECTION'
     __PCPU_ATTRS(sec) __typeof__(type) name
                                  ^~~~
>> include/linux/percpu-defs.h:185:46: note: in expansion of macro 'DEFINE_PER_CPU'
    #define DEFINE_PER_CPU_DECRYPTED(type, name) DEFINE_PER_CPU(type, name)
                                                 ^~~~~~~~~~~~~~
>> arch/x86/kernel/kvm.c:58:8: note: in expansion of macro 'DEFINE_PER_CPU_DECRYPTED'
    static DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible;
           ^~~~~~~~~~~~~~~~~~~~~~~~

vim +/__externally_visible__ +58 arch/x86/kernel/kvm.c

  > 10	#include <linux/context_tracking.h>
    11	#include <linux/init.h>
    12	#include <linux/kernel.h>
    13	#include <linux/kvm_para.h>
    14	#include <linux/cpu.h>
    15	#include <linux/mm.h>
    16	#include <linux/highmem.h>
    17	#include <linux/hardirq.h>
    18	#include <linux/notifier.h>
    19	#include <linux/reboot.h>
    20	#include <linux/hash.h>
    21	#include <linux/sched.h>
    22	#include <linux/slab.h>
    23	#include <linux/kprobes.h>
    24	#include <linux/debugfs.h>
    25	#include <linux/nmi.h>
    26	#include <linux/swait.h>
    27	#include <asm/timer.h>
    28	#include <asm/cpu.h>
    29	#include <asm/traps.h>
    30	#include <asm/desc.h>
    31	#include <asm/tlbflush.h>
    32	#include <asm/apic.h>
    33	#include <asm/apicdef.h>
    34	#include <asm/hypervisor.h>
    35	#include <asm/tlb.h>
    36	#include <asm/cpuidle_haltpoll.h>
    37	
    38	static int kvmapf = 1;
    39	
    40	static int __init parse_no_kvmapf(char *arg)
    41	{
    42	        kvmapf = 0;
    43	        return 0;
    44	}
    45	
    46	early_param("no-kvmapf", parse_no_kvmapf);
    47	
    48	static int steal_acc = 1;
    49	static int __init parse_no_stealacc(char *arg)
    50	{
    51	        steal_acc = 0;
    52	        return 0;
    53	}
    54	
    55	early_param("no-steal-acc", parse_no_stealacc);
    56	
    57	static DEFINE_PER_CPU_DECRYPTED(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64);
  > 58	static DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible;
    59	static int has_steal_clock = 0;
    60	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (35001 bytes)