linux-kernel - Re: [v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3797d4b4-180e-fb25-09ed-888385c04894@web.de>
Date:   Wed, 15 Apr 2020 09:12:20 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Xiao Yang <yangx.jy@...fujitsu.com>,
        linux-kselftest@...r.kernel.org, linux-trace-devel@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Xiao Yang <ice_yangxiao@....com>
Subject: Re: [v2] tracing: Fix the race between registering 'snapshot' event
 trigger and triggering 'snapshot' operation

>>> * Adjustment:
>>>    … operation (i. e. …
>> Hi Markus,
>>
>> Which part of description do you want to change or could you provide an
>> example for reference?

I proposed to insert two space characters in a wording.

> That part is fine for me.

Such a view can be fine if you would like to adjust the provided contents
another bit for the final commit message.

>> Do you mean to add the following "Fixes" tag?
>> Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
>
> Yeah, that fixes tag is appropriate.

I suggest to reconsider the influence of parentheses at such places.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=8632e9b5645bbc2331d21d892b0d6961c1a08429#n183

Regards,
Markus