linux-kernel - Re: [PATCH] component: Silence bind error on -EPROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o8rt5hdj.fsf@intel.com>
Date:   Wed, 15 Apr 2020 10:37:44 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     James Hilliard <james.hilliard1@...il.com>
Cc:     dri-devel@...ts.freedesktop.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] component: Silence bind error on -EPROBE_DEFER

On Tue, 14 Apr 2020, James Hilliard <james.hilliard1@...il.com> wrote:
> On Tue, Apr 14, 2020 at 5:07 AM Jani Nikula <jani.nikula@...ux.intel.com> wrote:
>>
>> On Fri, 10 Apr 2020, James Hilliard <james.hilliard1@...il.com> wrote:
>> > If a component fails to bind due to -EPROBE_DEFER we should not log an
>> > error as this is not a real failure.
>> >
>> > Fixes:
>> > vc4-drm soc:gpu: failed to bind 3f902000.hdmi (ops vc4_hdmi_ops): -517
>> > vc4-drm soc:gpu: master bind failed: -517
>>
>> I'd think the probe defer is useful information anyway. Maybe just tone
>> down the severity and/or the message?
> That's probably not needed as there's dev_dbg logging for -EPROBE_DEFER
> elsewhere from what it looks like.

If you say so; I don't have the time to go through all the code paths.

BR,
Jani.


>
> For example:
> https://github.com/torvalds/linux/blob/v5.6/drivers/base/dd.c#L621
>>
>> BR,
>> Jani.
>>
>> >
>> > Signed-off-by: James Hilliard <james.hilliard1@...il.com>
>> > ---
>> >  drivers/base/component.c | 9 ++++++---
>> >  1 file changed, 6 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/drivers/base/component.c b/drivers/base/component.c
>> > index e97704104784..157c6c790578 100644
>> > --- a/drivers/base/component.c
>> > +++ b/drivers/base/component.c
>> > @@ -256,7 +256,8 @@ static int try_to_bring_up_master(struct master *master,
>> >       ret = master->ops->bind(master->dev);
>> >       if (ret < 0) {
>> >               devres_release_group(master->dev, NULL);
>> > -             dev_info(master->dev, "master bind failed: %d\n", ret);
>> > +             if (ret != -EPROBE_DEFER)
>> > +                     dev_info(master->dev, "master bind failed: %d\n", ret);
>> >               return ret;
>> >       }
>> >
>> > @@ -611,8 +612,10 @@ static int component_bind(struct component *component, struct master *master,
>> >               devres_release_group(component->dev, NULL);
>> >               devres_release_group(master->dev, NULL);
>> >
>> > -             dev_err(master->dev, "failed to bind %s (ops %ps): %d\n",
>> > -                     dev_name(component->dev), component->ops, ret);
>> > +             if (ret != -EPROBE_DEFER) {
>> > +                     dev_err(master->dev, "failed to bind %s (ops %ps): %d\n",
>> > +                             dev_name(component->dev), component->ops, ret);
>> > +             }
>> >       }
>> >
>> >       return ret;
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center

-- 
Jani Nikula, Intel Open Source Graphics Center