linux-kernel - Re: [PATCH] firmware: xilinx: make firmware_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d17ad4d4-43a7-8cab-bbdd-f63d425a0abc@xilinx.com>
Date:   Wed, 15 Apr 2020 10:25:14 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Jason Yan <yanaijie@...wei.com>, michal.simek@...inx.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] firmware: xilinx: make firmware_debugfs_root static

On 15. 04. 20 10:43, Jason Yan wrote:
> Fix the following sparse warning:
> 
> drivers/firmware/xilinx/zynqmp-debug.c:38:15: warning: symbol
> 'firmware_debugfs_root' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/firmware/xilinx/zynqmp-debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp-debug.c b/drivers/firmware/xilinx/zynqmp-debug.c
> index c6d0724da4db..43bc6cfdab45 100644
> --- a/drivers/firmware/xilinx/zynqmp-debug.c
> +++ b/drivers/firmware/xilinx/zynqmp-debug.c
> @@ -35,7 +35,7 @@ static struct pm_api_info pm_api_list[] = {
>  	PM_API(PM_QUERY_DATA),
>  };
>  
> -struct dentry *firmware_debugfs_root;
> +static struct dentry *firmware_debugfs_root;
>  
>  /**
>   * zynqmp_pm_argument_value() - Extract argument value from a PM-API request
> 

Applied.

Thanks,
Michal