linux-kernel - Re: [PATCH v2] nvmem: core: don't consider subnodes not matching binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0dc571f-4faf-f75c-1388-d1fab10f4aa8@linaro.org>
Date:   Wed, 15 Apr 2020 09:46:06 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     devicetree@...r.kernel.org, Christian Eggers <CEggers@...i.de>,
        linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH v2] nvmem: core: don't consider subnodes not matching
 binding



On 15/04/2020 09:05, Ahmad Fatoum wrote:
>> - If the cell has a compatible node, it must be "nvmem-cell".
>>    Otherwise, a cell with a compatible node is skipped.
>>
This one sounds more sensible!
If we go this way, it needs to be properly documented in the bindings too.


>> - Adding a nvmem cell container with a compatible and making support for
>>    the old binding configurable

Older bindings should be still supported but we should encourage to use 
compatible string for new additions.

>>
>> - Skipping cells that are malformed and lack a reg = < > property_without_
>>    error
Currently we only support Offset and Size with address cell and size 
cells of 1. Adding an extra check here to see if its malformed makes 
sense too!


Thanks,
srini

> gentle ping. I can prepare another patch if you indicate which approach
> you'd prefer.
>