linux-kernel - Re: [PATCH] PCI: dwc: intel: make intel_pcie_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 15 Apr 2020 13:07:42 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     lorenzo.pieralisi@....com, amurray@...goodpenguin.co.uk,
        bhelgaas@...gle.com, p.zabel@...gutronix.de,
        gustavo.pimentel@...opsys.com, eswara.kota@...ux.intel.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static

On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
> 
> drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol
> 'intel_pcie_cpu_addr' was not declared. Should it be static?

Please, learn how to use get_maintainers.pl to avoid spamming people.
Hint:
	scripts/get_maintainer.pl --git --git-min-percent=67
would give advantage, though it still requires a common sense to be applied.

> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c
> index fc2a12212dec..2d8dbb318087 100644
> --- a/drivers/pci/controller/dwc/pcie-intel-gw.c
> +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c
> @@ -453,7 +453,7 @@ static int intel_pcie_msi_init(struct pcie_port *pp)
>  	return 0;
>  }
>  
> -u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
> +static u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
>  {
>  	return cpu_addr + BUS_IATU_OFFSET;
>  }
> -- 
> 2.21.1
> 

-- 
With Best Regards,
Andy Shevchenko