linux-kernel - Re: [PATCH 2/2] gpio: pca953x: Fix pca953x_gpio_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMpxmJU0sSDPTa-YHTEsYCzX3Vpv5YJAKhOhfhf73_rbL4jYSg@mail.gmail.com>
Date:   Wed, 15 Apr 2020 13:23:52 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Adam Ford <aford173@...il.com>
Cc:     linux-gpio <linux-gpio@...r.kernel.org>, aford@...conembedded.com,
        Linus Walleij <linus.walleij@...aro.org>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] gpio: pca953x: Fix pca953x_gpio_set_config

niedz., 12 kwi 2020 o 03:34 Adam Ford <aford173@...il.com> napisał(a):
>
> pca953x_gpio_set_config is setup to support pull-up/down
> bias.  Currently the driver uses a variable called 'config' to
> determine which options to use.  Unfortunately, this is incorrect.
>
> This patch uses function pinconf_to_config_param(config), which
> converts this 'config' parameter back to pinconfig to determine
> which option to use.
>
> Fixes: 15add06841a3 ("gpio: pca953x: add ->set_config implementation")
>
> Signed-off-by: Adam Ford <aford173@...il.com>
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index 5638b4e5355f..4269ea9a817e 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -531,7 +531,7 @@ static int pca953x_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
>  {
>         struct pca953x_chip *chip = gpiochip_get_data(gc);
>
> -       switch (config) {
> +       switch (pinconf_to_config_param(config)) {
>         case PIN_CONFIG_BIAS_PULL_UP:
>         case PIN_CONFIG_BIAS_PULL_DOWN:
>                 return pca953x_gpio_set_pull_up_down(chip, offset, config);
> --
> 2.25.1
>

Patch applied for fixes, thanks!

Bart