linux-kernel - Re: [PATCH v2] apparmor: fix potential label refcnt leak in aa_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9f36822-2483-9512-732b-b158ed104bf2@web.de>
Date:   Wed, 15 Apr 2020 13:27:57 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Xiyu Yang <xiyuyang19@...an.edu.cn>,
        Xin Tan <tanxin.ctf@...il.com>,
        linux-security-module@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, James Morris <jmorris@...ei.org>,
        John Johansen <john.johansen@...onical.com>,
        Kangjie Lu <kjlu@....edu>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        Yuan Zhang <yuanxzhang@...an.edu.cn>
Subject: Re: [PATCH v2] apparmor: fix potential label refcnt leak in
 aa_change_profile

> According to the comment of aa_get_current_label(), …

I suggest to make this wording clearer.
Would you like to refer to any software documentation here?


> However, when the original object pointed by "label" becomes
> unreachable because aa_change_profile() returns or a new object
> is assigned to "label", reference count increased by
> aa_get_current_label() is not decreased, causing a refcnt leak.

How do you think about to reduce abbreviations in the commit message?

Would you like to add the tag “Fixes” to the change description?

Regards,
Markus