linux-kernel - Re: [PATCH v2] tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Apr 2020 21:46:42 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Xiao Yang <yangx.jy@...fujitsu.com>
Cc:     Markus Elfring <Markus.Elfring@....de>,
        <linux-kselftest@...r.kernel.org>,
        <linux-trace-devel@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...hat.com>,
        Xiao Yang <ice_yangxiao@....com>
Subject: Re: [PATCH v2] tracing: Fix the race between registering 'snapshot'
 event trigger and triggering 'snapshot' operation

On Wed, 15 Apr 2020 09:40:20 +0800
Xiao Yang <yangx.jy@...fujitsu.com> wrote:

> On 2020/4/14 15:54, Markus Elfring wrote:
> >> Traced event can trigger 'snapshot' operation(i.e. calls snapshot_trigger()  
> >
> > I suggest to improve the change description.
> >
> > * Adjustment:
> >    … operation (i. e. …  
> Hi Markus,
> 
> Which part of description do you want to change or could you provide an 
> example for reference?

That part is fine for me.

> 
> >
> > * Will the tag “Fixes” become relevant?  
> 
> Do you mean to add the following "Fixes" tag?
> Fixes: 93e31ffbf417 "tracing: Add 'snapshot' event trigger command"
> 

Yeah, that fixes tag is appropriate. But I usually add those myself, you
don't need to resend.

-- Steve