linux-kernel - Re: [PATCH] seqlock: Use while instead of if+goto in __read_seqcount

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200415114441.GG20730@hirez.programming.kicks-ass.net>
Date:   Wed, 15 Apr 2020 13:44:41 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Will Deacon <will@...nel.org>
Cc:     Muchun Song <songmuchun@...edance.com>, mingo@...hat.com,
        mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] seqlock: Use while instead of if+goto in
 __read_seqcount_begin

On Tue, Apr 14, 2020 at 02:48:31PM +0100, Will Deacon wrote:
> Oh yeah, good thinking. Didn't spot that one, but it should work well as
> long as smp_cond_load_relaxed() always implies a control dependency (surely
> it has to?)

Well, yeah, but then you know as well as I do that compilers are dodgy
pieces of crap which are out to get you. Still, I too can't see how it
could mess this up.