linux-kernel - Re: [PATCH v1 1/1] i2c: iproc: generate stop event for slave writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200415122945.GC910@ninjato>
Date:   Wed, 15 Apr 2020 14:29:45 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>
Cc:     Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Lori Hikichi <lori.hikichi@...adcom.com>,
        Shreesha Rajashekar <shreesha.rajashekar@...adcom.com>,
        Nishka Dasgupta <nishkadg.linux@...il.com>,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] i2c: iproc: generate stop event for slave writes

On Sun, Mar 22, 2020 at 11:50:19PM +0530, Rayagonda Kokatanur wrote:
> When slave status is I2C_SLAVE_RX_END, generate I2C_SLAVE_STOP
> event to i2c_client.
> 
> Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode")
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@...adcom.com>

Just to make sure: That means the HW has already detected a STOP
condition on the bus?

> ---
>  drivers/i2c/busses/i2c-bcm-iproc.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c
> index 30efb7913b2e..b58224b7ba79 100644
> --- a/drivers/i2c/busses/i2c-bcm-iproc.c
> +++ b/drivers/i2c/busses/i2c-bcm-iproc.c
> @@ -360,6 +360,9 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c,
>  			value = (u8)((val >> S_RX_DATA_SHIFT) & S_RX_DATA_MASK);
>  			i2c_slave_event(iproc_i2c->slave,
>  					I2C_SLAVE_WRITE_RECEIVED, &value);
> +			if (rx_status == I2C_SLAVE_RX_END)
> +				i2c_slave_event(iproc_i2c->slave,
> +						I2C_SLAVE_STOP, &value);
>  		}
>  	} else if (status & BIT(IS_S_TX_UNDERRUN_SHIFT)) {
>  		/* Master read other than start */
> -- 
> 2.17.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)