linux-kernel - Re: [PATCH] KVM: SVM: fix compilation with modular PSP and non-modular KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a2965bb4-42f3-7961-aaba-66f031197dff@redhat.com>
Date:   Thu, 16 Apr 2020 16:14:43 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Tom Lendacky <thomas.lendacky@....com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Cc:     ubizjak@...il.com
Subject: Re: [PATCH] KVM: SVM: fix compilation with modular PSP and
 non-modular KVM

On 16/04/20 15:57, Tom Lendacky wrote:
> On 4/13/20 2:50 AM, Paolo Bonzini wrote:
>> Use svm_sev_enabled() in order to cull all calls to PSP code.  Otherwise,
>> compilation fails with undefined symbols if the PSP device driver is
>> compiled
>> as a module and KVM is not.
> 
> The Kconfig support will set CONFIG_KVM_AMD_SEV to "n" in this
> situation, so it might be worth seeing if sev.o could be removed from
> the build at that point. I'll try and look at that when I get a chance,
> but I'm currently buried with a ton of other work.

It could be made to work, but you would have to add stubs to sev.h.

Paolo