linux-kernel - Re: [PATCH 1/1] selftests: kvm: Add overlapped memory regions test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d05b77b-1e8b-2dfd-cbc9-5b09b685b630@redhat.com>
Date:   Thu, 16 Apr 2020 15:53:36 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Krish Sadhukhan <krish.sadhukhan@...cle.com>,
        Wainer dos Santos Moschetta <wainersm@...hat.com>,
        kvm@...r.kernel.org
Cc:     drjones@...hat.com, sean.j.christopherson@...el.com,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 1/1] selftests: kvm: Add overlapped memory regions test

On 16/04/20 01:57, Krish Sadhukhan wrote:
> 
>> Add the test_overlap_memory_regions() test case in
>> set_memory_region_test. This should check that overlapping
>> memory regions on the guest physical address cannot be added.
> 
> 
> I think the commit header and the body need some improvement. For example,
> 
>         Header: Test that overlapping guest memory regions can not be added
> 
>         Body:  Enhance the existing tests in set_memory_region_test.c so
> that it tests overlapping guest
> 
>                     memory regions. The new test verifies that adding
> overlapping guest memory regions fails.

I like Wainer's header and your body. :)

Paolo