linux-kernel - Re: [PATCH v2] gpio: gpio-pca953x, Add get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD56B7ezM5ewaFySr8zeybHvkLmLpcZQzMgYUnVNEvdJnvgGZw@mail.gmail.com>
Date:   Thu, 16 Apr 2020 09:40:44 -0400
From:   Paul Thomas <pthomas8589@...il.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] gpio: gpio-pca953x, Add get_multiple function

On Thu, Apr 16, 2020 at 9:21 AM Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:
>
> czw., 16 kwi 2020 o 13:22 Linus Walleij <linus.walleij@...aro.org> napisał(a):
> >
> > On Tue, Apr 14, 2020 at 5:30 PM Paul Thomas <pthomas8589@...il.com> wrote:
> >
> > > Implement a get_multiple function for gpio-pca953x. If a driver
> > > leaves get_multiple unimplemented then gpio_chip_get_multiple()
> > > in gpiolib.c takes care of it by calling chip->get() as needed.
> > > For i2c chips this is very inefficient. For example if you do an
> > > 8-bit read then instead of a single i2c transaction there are
> > > 8 transactions reading the same byte!
> > >
> > > This has been tested with max7312 chips on a 5.2 kernel.
> > >
> > > Signed-off-by: Paul Thomas <pthomas8589@...il.com>
> > > ---
> > >  changes from v1: rebased to 5.7-rc1
> >
> > Acked-by: Linus Walleij <linus.walleij@...aro.org>
> >
> > Since I know Bartosz is queueing other patches for this driver I
> > let him pick it up.
> >
> > Yours,
> > Linus Walleij
>
> Patch applied. I removed the last line of the commit message since I
> guess you did test it on v5.7-rc1 after all?
I applied the patch and compiled the kernel, but I didn't test on our
embedded board with the actual max7312 chips, that board has a whole
series of special commits.

-Paul

>
> Bart