linux-kernel - Re: [PATCH] hugetlb_cgroup: remove unused variable 'i'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHS8izNenS4ZW3fxFtJ-jzZ9QwP192N3KPB7n6qQrVcoP8PNgg@mail.gmail.com>
Date:   Wed, 15 Apr 2020 17:29:00 -0700
From:   Mina Almasry <almasrymina@...gle.com>
To:     Ralph Campbell <rcampbell@...dia.com>
Cc:     linux-kselftest@...r.kernel.org, Linux-MM <linux-mm@...ck.org>,
        open list <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Shuah Khan <shuah@...nel.org>,
        Mike Kravetz <mike.kravetz@...cle.com>
Subject: Re: [PATCH] hugetlb_cgroup: remove unused variable 'i'

On Wed, Apr 15, 2020 at 5:26 PM Ralph Campbell <rcampbell@...dia.com> wrote:
>
> Compiling tests in tools/testing/selftests/vm/ results in a C compiler
> warning:
>
> write_to_hugetlbfs.c: In function ‘main’:
> write_to_hugetlbfs.c:77:16: warning: unused variable ‘i’
>    77 |  unsigned long i;
>
> Delete the unused variable.
>
> Fixes: 29750f71a9b4 ("hugetlb_cgroup: add hugetlb_cgroup reservation tests")
> Signed-off-by: Ralph Campbell <rcampbell@...dia.com>

Whoops, sorry about that.

Reviewed-by: Mina Almasry <almasrymina@...gle.com>

> ---
>  tools/testing/selftests/vm/write_to_hugetlbfs.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/tools/testing/selftests/vm/write_to_hugetlbfs.c b/tools/testing/selftests/vm/write_to_hugetlbfs.c
> index 110bc4e4015d..6a2caba19ee1 100644
> --- a/tools/testing/selftests/vm/write_to_hugetlbfs.c
> +++ b/tools/testing/selftests/vm/write_to_hugetlbfs.c
> @@ -74,8 +74,6 @@ int main(int argc, char **argv)
>         int write = 0;
>         int reserve = 1;
>
> -       unsigned long i;
> -
>         if (signal(SIGINT, sig_handler) == SIG_ERR)
>                 err(1, "\ncan't catch SIGINT\n");
>
> --
> 2.25.2
>