linux-kernel - Re: [PATCH v4] mm/ksm: Fix NULL pointer dereference when KSM zero page is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <039d201a-a5fc-5ce2-54a1-f236531f9829@web.de>
Date:   Thu, 16 Apr 2020 08:00:36 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Muchun Song <songmuchun@...edance.com>,
        Xiongchun Duan <duanxiongchun@...edance.com>,
        linux-mm@...ck.org
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Hildenbrand <david@...hat.com>,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        Yang Shi <yang.shi@...ux.alibaba.com>
Subject: Re: [PATCH v4] mm/ksm: Fix NULL pointer dereference when KSM zero
 page is enabled

> to a crash when we access vm_mm(its offset is 0x40) later in

Would the text variant “… vm_mm (its …” be a bit nicer?


…
> +++ b/mm/ksm.c
> @@ -2112,8 +2112,15 @@ static void cmp_and_merge_page(struct page *page, struct rmap_item *rmap_item)
…
> +		if (vma)
> +			err = try_to_merge_one_page(vma, page,
> +					ZERO_PAGE(rmap_item->address));

Can the parameter alignment trigger further software development considerations
for such a function call?

Regards,
Markus