[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200416170416.GH4796@pendragon.ideasonboard.com>
Date: Thu, 16 Apr 2020 20:04:16 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc: linux-kernel@...r.kernel.org,
Collabora Kernel ML <kernel@...labora.com>,
matthias.bgg@...il.com, drinkcat@...omium.org, hsinyi@...omium.org,
sam@...nborg.org, Andrzej Hajda <a.hajda@...sung.com>,
Daniel Vetter <daniel@...ll.ch>,
David Airlie <airlied@...ux.ie>,
Jernej Skrabec <jernej.skrabec@...l.net>,
Jonas Karlman <jonas@...boo.se>,
Neil Armstrong <narmstrong@...libre.com>,
dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH 2/2] drm/bridge: ps8640: Let panel to set the connector
type
Hi Enric,
Thank you for the patch.
On Thu, Apr 16, 2020 at 06:44:04PM +0200, Enric Balletbo i Serra wrote:
> The panel connector type should be set by the panel not the bridge, so
> remove the connector_type assignment.
>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> ---
>
> drivers/gpu/drm/bridge/parade-ps8640.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/parade-ps8640.c b/drivers/gpu/drm/bridge/parade-ps8640.c
> index 956b76e0a44d..13755d278db6 100644
> --- a/drivers/gpu/drm/bridge/parade-ps8640.c
> +++ b/drivers/gpu/drm/bridge/parade-ps8640.c
> @@ -278,8 +278,6 @@ static int ps8640_probe(struct i2c_client *client)
> if (!panel)
> return -ENODEV;
>
> - panel->connector_type = DRM_MODE_CONNECTOR_eDP;
> -
> ps_bridge->panel_bridge = devm_drm_panel_bridge_add(dev, panel);
> if (IS_ERR(ps_bridge->panel_bridge))
> return PTR_ERR(ps_bridge->panel_bridge);
--
Regards,
Laurent Pinchart
Powered by blists - more mailing lists