linux-kernel - Re: [PATCH v2] i2c: busses: remove duplicate dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 16 Apr 2020 20:22:33 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dejin Zheng <zhengdejin5@...il.com>, linux-i2c@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Thor Thayer <thor.thayer@...ux.intel.com>,
        Tang Bin <tangbin@...s.chinamobile.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Patrick Williams <alpawi@...zon.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Krzysztof Adamski <krzysztof.adamski@...ia.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Barry Song <baohua@...nel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Dong Aisheng <aisheng.dong@....com>,
        George Cherian <gcherian@...vell.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Neil Armstrong <narmstrong@...libre.com>
Subject: Re: [PATCH v2] i2c: busses: remove duplicate dev_err()

> it will print an error message by itself when platform_get_irq()
> goes wrong. so don't need dev_err() in here again.

I suggest to improve the commit message considerably.

Would you like to integrate any information from a response
on the topic “drm/meson: Delete an error message in meson_dw_hdmi_bind()” by
a contributor like Neil Armstrong?
https://lore.kernel.org/dri-devel/54e0b6e4-4a39-c567-7355-2b2330a95294@baylibre.com/
https://lore.kernel.org/patchwork/comment/1418937/
https://lkml.org/lkml/2020/4/15/186

> v1 -> v2:

Will a version identification be sufficient without the arrow?

> 	- add 19 similar changes by Markus's suggestion.

* With which search tool did you find the presented update candidates?

* Will a link to the commit “driver core: platform: Add an error message
  to platform_get_irq*()” (by Stephen Boyd from 2019-07-29) become helpful
  as background information for such collateral evolution?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/base/platform.c?id=7723f4c5ecdb8d832f049f8483beb0d1081cedf6

Regards,
Markus