linux-kernel - Re: [PATCH 1/1] HID: mcp2221: add GPIO functionality support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2004162212080.19713@cbobk.fhfr.pm>
Date:   Thu, 16 Apr 2020 22:15:27 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Rishi Gupta <gupt21@...il.com>
cc:     linus.walleij@...aro.org, bgolaszewski@...libre.com,
        benjamin.tissoires@...hat.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH 1/1] HID: mcp2221: add GPIO functionality support

On Tue, 14 Apr 2020, Rishi Gupta wrote:

> MCP2221 has 4 pins that can be used as GPIO or configured
> for alternate functionality such as clock generation and
> IRQ detection. This patch adds support for GPIO functionality.
> 
> To set direction of a pin or to toggle its state after it
> has been configured as GPIO, driver sends command to mcp2221
> and parses response received from mcp2221. Based on this
> response either 0 or appropriate error code is returned to
> GPIO framework.
> 
> To get the direction or current state of a pin, driver
> sends command and read response from the device. Based on
> the response received from device direction or value
> is sent to the GPIO framework.
> 
> Command from driver to mcp2221 device are output report.
> Response received from mcp2221 is input report.
> 
> Datasheet (page 45-48) contains details about how to decode
> the response received from device:
> http://ww1.microchip.com/downloads/en/DeviceDoc/20005565B.pdf
> 
> Signed-off-by: Rishi Gupta <gupt21@...il.com>
> ---
>  drivers/hid/hid-mcp2221.c | 169 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 169 insertions(+)

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs