linux-kernel - Re: [PATCH v2] i2c: busses: remove duplicate dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vdd8SzrzXuxTTtkqRBWZuebhumJfv_fBPqdKwe780_ZEQ@mail.gmail.com>
Date:   Fri, 17 Apr 2020 00:29:20 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Markus Elfring <Markus.Elfring@....de>,
        Dejin Zheng <zhengdejin5@...il.com>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Thor Thayer <thor.thayer@...ux.intel.com>,
        Tang Bin <tangbin@...s.chinamobile.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Patrick Williams <alpawi@...zon.com>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Krzysztof Adamski <krzysztof.adamski@...ia.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Ard Biesheuvel <ardb@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Barry Song <baohua@...nel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Dong Aisheng <aisheng.dong@....com>,
        George Cherian <gcherian@...vell.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        Neil Armstrong <narmstrong@...libre.com>
Subject: Re: [PATCH v2] i2c: busses: remove duplicate dev_err()

On Fri, Apr 17, 2020 at 12:28 AM Joe Perches <joe@...ches.com> wrote:
>
> On Thu, 2020-04-16 at 20:22 +0200, Markus Elfring wrote:
> > > it will print an error message by itself when platform_get_irq()
> > > goes wrong. so don't need dev_err() in here again.
> >
> > I suggest to improve the commit message considerably.
>
> I suggest you ignore Markus' suggestion.
>
> The commit message is OK.
>
> The subject _could_ have included "platform_get_irq" something like
>
> Subject: [PATCH v2] i2c: busses: Remove platform_get_irq()'s duplicated dev_err()
>
> but I believe it's not important enough to redo.

+1, I think it's good enough.

-- 
With Best Regards,
Andy Shevchenko