[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200416183244-mutt-send-email-mst@kernel.org>
Date: Thu, 16 Apr 2020 18:32:56 -0400
From: "Michael S. Tsirkin" <mst@...hat.com>
To: Eugenio Pérez <eperezma@...hat.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
"virtualization@...ts.linux-foundation.org"
<virtualization@...ts.linux-foundation.org>,
Christian Borntraeger <borntraeger@...ibm.com>,
Linux Next Mailing List <linux-next@...r.kernel.org>,
kvm list <kvm@...r.kernel.org>,
Cornelia Huck <cohuck@...hat.com>,
Halil Pasic <pasic@...ux.ibm.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 5/8] tools/virtio: Use __vring_new_virtqueue in
virtio_test.c
On Thu, Apr 16, 2020 at 09:56:40AM +0200, Eugenio Pérez wrote:
> As updated in ("2a2d1382fe9d virtio: Add improved queue allocation API")
>
> Signed-off-by: Eugenio Pérez <eperezma@...hat.com>
Pls add motivation for these changes.
> ---
> tools/virtio/virtio_test.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> index 1d5144590df6..d9827b640c21 100644
> --- a/tools/virtio/virtio_test.c
> +++ b/tools/virtio/virtio_test.c
> @@ -106,10 +106,9 @@ static void vq_info_add(struct vdev_info *dev, int num)
> assert(r >= 0);
> memset(info->ring, 0, vring_legacy_size(num, 4096));
> vring_legacy_init(&info->vring, num, info->ring, 4096);
> - info->vq = vring_new_virtqueue(info->idx,
> - info->vring.num, 4096, &dev->vdev,
> - true, false, info->ring,
> - vq_notify, vq_callback, "test");
> + info->vq =
> + __vring_new_virtqueue(info->idx, info->vring, &dev->vdev, true,
> + false, vq_notify, vq_callback, "test");
> assert(info->vq);
> info->vq->priv = info;
> vhost_vq_setup(dev, info);
> --
> 2.18.1
Powered by blists - more mailing lists